Skip to content

chore: Automatically wrap direct calls to oracles from ACIR in a proxy function#10827

Merged
jfecher merged 2 commits intoaf/10298-global-oracle-2from
af/auto-wrap-oracle-calls
Dec 5, 2025
Merged

chore: Automatically wrap direct calls to oracles from ACIR in a proxy function#10827
jfecher merged 2 commits intoaf/10298-global-oracle-2from
af/auto-wrap-oracle-calls

Conversation

@aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Dec 5, 2025

Description

Problem

Resolves #9671

Summary

Adds a step to the proxies pass to automatically wrap direct calls to oracle functions made from constrained functions into an unconstrained proxy. Remove the lint that denied this.

Additional Context

Since #10826 relaxes the lint for oracles called from constrained functions via variables, and we already had the machinery to wrap them into proxy functions, it was a small leap to also do this for direct calls.

User Documentation

Check one:

  • No user documentation needed.
  • Changes in docs/ included in this PR.
  • [For Experimental Features] Changes in docs/ to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Changes to number of Brillig opcodes executed

Generated at commit: d2afe340067feb63d6372c9560066450899d7523, compared to commit: 4f8b5b75f17a682191b410b533c2b0bf77b2214a

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
embedded_curve_ops_inliner_zero -96 ✅ -32.88%

Full diff report 👇
Program Brillig opcodes (+/-) %
embedded_curve_ops_inliner_zero 196 (-96) -32.88%

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Changes to Brillig bytecode sizes

Generated at commit: d2afe340067feb63d6372c9560066450899d7523, compared to commit: 4f8b5b75f17a682191b410b533c2b0bf77b2214a

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
embedded_curve_ops_inliner_zero -67 ✅ -23.84%
regression_7744_inliner_min -39 ✅ -40.63%

Full diff report 👇
Program Brillig opcodes (+/-) %
embedded_curve_ops_inliner_zero 214 (-67) -23.84%
regression_7744_inliner_min 57 (-39) -40.63%

@jfecher jfecher merged commit 9118a4a into af/10298-global-oracle-2 Dec 5, 2025
134 checks passed
@jfecher jfecher deleted the af/auto-wrap-oracle-calls branch December 5, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants